Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add kubeletstats, k8sevents, k8scluster receivers to NRDOT #101

Closed
wants to merge 1 commit into from

Conversation

csongnr
Copy link

@csongnr csongnr commented May 9, 2024

No description provided.

@csongnr csongnr requested a review from a team May 9, 2024 23:14
@csongnr csongnr closed this May 9, 2024
@csongnr csongnr reopened this May 9, 2024
@csongnr
Copy link
Author

csongnr commented May 9, 2024

I tried to run make licenses but got this error:

/Library/Developer/CommandLineTools/usr/bin/make -C internal/tools
go install go.elastic.co/go-licence-detector
Distributions to build: nr-otel-collector
Building: nr-otel-collector
Using Builder: /Users/csong/bin/ocb
Using Go: /opt/homebrew/bin/go
✅ SUCCESS: distribution 'nr-otel-collector' built.
/Library/Developer/CommandLineTools/usr/bin/make -C distributions/nr-otel-collector third-party-notices
go-license-detector tool not found, install it from the base directory with "make internal/tools"
make[2]: *** [third-party-notices] Error 1
make[1]: *** [distributions/nr-otel-collector] Error 2
make: *** [licenses] Error 2

so i tried to run make internal/tools
and got this:

/Library/Developer/CommandLineTools/usr/bin/make -C internal/tools
go install go.elastic.co/go-licence-detector 

and then tried to run make licenses again, but to no avail.
i also tried manually fetching
go install go.elastic.co/[email protected]
but still no dice, so i just manually updated the apache license file in the THIRD_PARTY_NOTICES.MD
that was probably not the way to go, let me know if i need to do something else to get this to work, thanks

i forked this repo to open the PR, in case that matters

@rubenruizdegauna
Copy link
Contributor

Hi @csongnr , what version of Go are you using? I tried with Go 1.20.10 and worked. I created and merged another PR attributing this #103 with another bump or vulnerable internal tools.

@csongnr
Copy link
Author

csongnr commented May 14, 2024

thanks @rubenruizdegauna

@csongnr csongnr closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants