feat: Move to multiple distro and simplify ci #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mailo-nr
force-pushed
the
marsac/move-nightly-configs
branch
21 times, most recently
from
de6673d to
9d9f60c
Compare
mailo-nr
changed the title
mailo-nr
force-pushed
the
marsac/move-nightly-configs
branch
from
9d9f60c to
8898dd4
Compare
kb-newrelic
reviewed
Jan 29, 2025
.github/workflows/ci.yaml
Outdated
Comment on lines
43
to
48
| - name: Login to Docker | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: docker.io | ||
| username: ${{ secrets.OTELCOMM_DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.OTELCOMM_DOCKERHUB_PASSWORD }} |
There was a problem hiding this comment.
Do we need this step? My naive thinking is that this workflow would never need to log into docker as it won't publish anything and the built image will only be used locally. Am I missing something?
I am mainly thinking that we have a risk of accidentally publishing something and without the rc in the image name, it would end up in a public repo looking like an official release?
kb-newrelic
reviewed
Jan 29, 2025
| - newrelic/nr-otel-collector:{{ .Version }}-amd64 | ||
| - newrelic/nr-otel-collector:latest-amd64 | ||
| extra_files: | ||
| - config.yaml |
There was a problem hiding this comment.
Unless I am missing something, this doesn't align with the current naming and location of the configs? Either the default config would need to be moved up one level to the distro folder or this references the specific config which will be the default
mailo-nr
force-pushed
the
marsac/move-nightly-configs
branch
from
8898dd4 to
b8eea61
Compare
mailo-nr
force-pushed
the
marsac/move-nightly-configs
branch
2 times, most recently
from
9548f31 to
e898a3c
Compare
mailo-nr
force-pushed
the
marsac/move-nightly-configs
branch
4 times, most recently
from
fdee542 to
bf1aa58
Compare
mailo-nr
force-pushed
the
marsac/move-nightly-configs
branch
from
bf1aa58 to
83b61aa
Compare
mailo-nr
force-pushed
the
marsac/move-nightly-configs
branch
from
83b61aa to
21d8f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.