Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nrdot-collector-host distro #202

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Jan 28, 2025

Summary

  • Added host distro named nrdot-collector-host. Files are copied from nr-otel-collector and modified as necessary:
    • Removed feature gate (--feature-gates=-pkg.translator.prometheus.NormalizeName) from default args (Dockerfile and .conf file) as distro does not contain prometheus-related components
    • Removed ports 55678 and 55679 from docker EXPOSE as they are related to OpenCensus which we do not use
    • Bumped provider versions to 1.24.0 to match component version of 0.118.0 (see otel release notes)
      • Added missing providers to k8s manifest
  • Rearranged/added README content to support multiple distros

@kb-newrelic kb-newrelic force-pushed the kbauer/prepare-host-distro branch from 743f13d to 3348915 Compare January 28, 2025 16:16
@kb-newrelic kb-newrelic force-pushed the kbauer/prepare-host-distro branch 4 times, most recently from 15dded0 to 7306f93 Compare January 28, 2025 20:39
@kb-newrelic kb-newrelic force-pushed the kbauer/prepare-host-distro branch 2 times, most recently from 3feec89 to 032294e Compare February 4, 2025 21:35
@kb-newrelic kb-newrelic marked this pull request as ready for review February 4, 2025 21:45
@kb-newrelic kb-newrelic requested a review from a team as a code owner February 4, 2025 21:45
@kb-newrelic kb-newrelic force-pushed the kbauer/prepare-host-distro branch from 032294e to dfd08f4 Compare February 4, 2025 21:46
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kb-newrelic kb-newrelic merged commit 3158482 into main Feb 5, 2025
6 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/prepare-host-distro branch February 5, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants