Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert normalizing host.name in query #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kb-newrelic
Copy link
Contributor

Summary

  • Reverting the 'normalization' of the distro in the host name as it causes nightly to fail. I initially thought it would be worth for readability but it also forces normalizing it in terraform which just becomes cumbersome to remember. If readability becomes an issue, adopting a different separator than - might be preferable than trying to shoehorn all segments that naturally contain hyphens into using a different character.

@kb-newrelic kb-newrelic requested a review from a team as a code owner January 29, 2025 01:15
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants