fix tests

newrelic · Apr 3, 2024 · ed58bb2 · ed58bb2
1 parent cbf6778
commit ed58bb2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/push_pr.yaml b/.github/workflows/push_pr.yaml
@@ -50,6 +50,7 @@ jobs:
     name: Run tests
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/checkout@v4
       - name: Check if CHANGELOG is valid
         uses: ./validate-markdown
 

diff --git a/src/changelog/linker/mapper/leadingv_test.go b/src/changelog/linker/mapper/leadingv_test.go
@@ -48,7 +48,7 @@ func TestLeadingVCheck_Map(t *testing.T) {
 			name:    "Check passed with leading v",
 			wrapped: &mapperMock{link: "link"},
 			dep:     changelog.Dependency{To: semver.MustParse("v1.2.3")},
-			checkLink: func(link string) (bool, error) {
+			checkLink: func(_ string) (bool, error) {
 				return link == "link-v1.2.3", nil
 			},
 			expected:    "link-v1.2.3",
@@ -58,7 +58,7 @@ func TestLeadingVCheck_Map(t *testing.T) {
 			name:    "Check passed without leading v",
 			wrapped: &mapperMock{link: "link"},
 			dep:     changelog.Dependency{To: semver.MustParse("1.2.3")},
-			checkLink: func(link string) (bool, error) {
+			checkLink: func(_ string) (bool, error) {
 				return link == "link-1.2.3", nil
 			},
 			expected:    "link-1.2.3",
@@ -68,7 +68,7 @@ func TestLeadingVCheck_Map(t *testing.T) {
 			name:    "Needs prepending v to pass the check",
 			wrapped: &mapperMock{link: "link"},
 			dep:     changelog.Dependency{To: semver.MustParse("1.2.3")},
-			checkLink: func(link string) (bool, error) {
+			checkLink: func(_ string) (bool, error) {
 				return link == "link-v1.2.3", nil
 			},
 			expected:    "link-v1.2.3",
@@ -78,7 +78,7 @@ func TestLeadingVCheck_Map(t *testing.T) {
 			name:    "Needs removing v to pass the check",
 			wrapped: &mapperMock{link: "link"},
 			dep:     changelog.Dependency{To: semver.MustParse("v1.2.3")},
-			checkLink: func(link string) (bool, error) {
+			checkLink: func(_ string) (bool, error) {
 				return link == "link-1.2.3", nil
 			},
 			expected:    "link-1.2.3",
@@ -88,7 +88,7 @@ func TestLeadingVCheck_Map(t *testing.T) {
 			name:    "Check will not pass even prepending v",
 			wrapped: &mapperMock{link: "link"},
 			dep:     changelog.Dependency{To: semver.MustParse("1.2.3")},
-			checkLink: func(link string) (bool, error) {
+			checkLink: func(_ string) (bool, error) {
 				return false, nil
 			},
 			expected:    "",
@@ -98,7 +98,7 @@ func TestLeadingVCheck_Map(t *testing.T) {
 			name:    "Check will not pass even removing v",
 			wrapped: &mapperMock{link: "link"},
 			dep:     changelog.Dependency{To: semver.MustParse("v1.2.3")},
-			checkLink: func(link string) (bool, error) {
+			checkLink: func(_ string) (bool, error) {
 				return false, nil
 			},
 			expected:    "",
@@ -108,7 +108,7 @@ func TestLeadingVCheck_Map(t *testing.T) {
 			name:    "Check returns an error",
 			wrapped: &mapperMock{link: "link"},
 			dep:     changelog.Dependency{To: semver.MustParse("1.2.3")},
-			checkLink: func(link string) (bool, error) {
+			checkLink: func(_ string) (bool, error) {
 				return false, errors.New("")
 			},
 			expected:    "link-1.2.3", // It uses the link from the underlying mapper.