Output major and minor version on next-version command (NR-233241)
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kang-makes
force-pushed
the
feat/output-major-minor-version
branch
from
e85d0ab
to
befb816
Compare
kang-makes
force-pushed
the
feat/output-major-minor-version
branch
from
3f14b4c
to
3896131
Compare
kang-makes
changed the title
next-version commandnext-version command (NR-233241)
sigilioso
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Thank you!
I think we should document the new outputs in the corresponding README file.
kang-makes
force-pushed
the
feat/output-major-minor-version
branch
from
cc83ba8
to
af3c65d
Compare
sigilioso
reviewed
Apr 4, 2024
sigilioso
reviewed
Apr 4, 2024
|
I do not have my head where I should... Solved on #216dc52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to tag actions and docker images by major. Something like:
newrelic/release-toolkit@1.We want the action that outputs the version to also output the major and minor versions so we can use it on different steps.