annotate.tpl.html: avoid this.remove(): it crashes IE #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under IE 10, this.remove() raises an exception which is not handled and stops the JavaScript interpreter. Waiting for a more comprehensive groking of JavaScript, use a hack to circumvent the problem with IE: replace the DOM object to be replaced with an empty string.
alemela
added a commit
that referenced
this pull request
Jun 16, 2014
annotate.tpl.html: avoid this.remove(): it crashes IE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under IE 10, this.remove() raises an exception which is not handled and stops the JavaScript interpreter.
Waiting for a more comprehensive groking of JavaScript, use a hack to circumvent the problem with IE: replace the DOM object to be replaced with an empty string.
Tested on IE 10, Firefox 30.0 and Chromium 34.