Importing rss and posts from blogs #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,6 +106,9 @@ def _savepost(link, pathname): | |||
|
|
|||
| def process_site(site): | |||
| """ Process the feeds of a site """ | |||
| is_site = re.compile("^([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$") | |||
There was a problem hiding this comment.
Could you explain me the rationale of this regexp?
There was a problem hiding this comment.
Divide it mentally in three groups with brackets. First group check domains >= level 2. Second group check first level domain. Third group check the local path. Lastly an optional slash.
In this way the string to pass must be a little structured.
There was a problem hiding this comment.
I think here can use the analogous for Python (urlparse.urlsplit, IIRC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main_rss.py: changed bitly conversion with a hash one, added the possibility to save rss.xml, added an url regexp matching step.
rssFetch.js: read blogs url, check if valid and pass them to main_rss.py