Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable drift velocities #261

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Add configurable drift velocities #261

merged 3 commits into from
Jan 30, 2025

Conversation

kvjmistry
Copy link
Collaborator

The NEXT100 drift velocities for the active and EL region were not configurable. This PR enables this option.

gonzaponte
gonzaponte approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds the option to set the active and EL electron drift velocities from config file. This is relevant for fullsim only, as fastsim does not propagate ionization electrons.

Good job!

gonzaponte
gonzaponte approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@gonzaponte gonzaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formally approved again.

@gonzaponte gonzaponte merged commit 0af90e4 into next-exp:master Jan 30, 2025
1 check passed
@kvjmistry kvjmistry deleted the drift_velocity branch January 30, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzaponte gonzaponte gonzaponte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvjmistry @gonzaponte