Step2 - 사다리(생성) #2315
Open
Step2 - 사다리(생성) #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooose
requested changes
Apr 5, 2025
Comment on lines
16
to
28
| public void printLadders(List<List<Boolean>> ladders) { | ||
| for(List<Boolean> ladder : ladders) { | ||
| System.out.print(" "); | ||
| for(Boolean connected : ladder) { | ||
| if(connected) { | ||
| System.out.print("|-----"); | ||
| } else { | ||
| System.out.print("| "); | ||
| } | ||
| } | ||
| System.out.println("|"); | ||
| } | ||
| } |
There was a problem hiding this comment.
depth가 깊어보이는데 스트림과 메소드 추출을 활용하면 좋겠습니다!
Suggested change
| public void printLadders(List<List<Boolean>> ladders) { | |
| for(List<Boolean> ladder : ladders) { | |
| System.out.print(" "); | |
| for(Boolean connected : ladder) { | |
| if(connected) { | |
| System.out.print("|-----"); | |
| } else { | |
| System.out.print("| "); | |
| } | |
| } | |
| System.out.println("|"); | |
| } | |
| } | |
| public void printLadders(List<List<Boolean>> ladders) { | |
| for (List<Boolean> ladder : ladders) { | |
| var lines = ladder.stream() | |
| .map(this::make) | |
| .collect(Collectors.joining("", " ", "|")); | |
| System.out.println(lines); | |
| } | |
| } | |
| private String make(boolean connected) { | |
| if (connected) { | |
| return "|-----"; | |
| } | |
| return "| "; | |
| } |
메소드 이름은 예시이니 참고만 해주세요!
Comment on lines
+19
to
+25
| public List<List<Boolean>> getLadder() { | ||
| return lines.getList(); | ||
| } | ||
|
|
||
| public List<String> getNames() { | ||
| return names.getAll(); | ||
| } |
There was a problem hiding this comment.
이 부분도
값을 풀어서 제공하고 있네요
혹시 외부에서 사용할 때 디미터 법칙을 지키기 위함일까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 2단계 사다리 타기 미션도 잘부탁드려요 🥰