Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸš€ 3단계 - 둜또(2λ“±) #4158

Merged
merged 10 commits into from
Apr 8, 2025
Merged

πŸš€ 3단계 - 둜또(2λ“±) #4158

merged 10 commits into from
Apr 8, 2025

Conversation

younghooniii
Copy link

No description provided.

@younghooniii
Copy link
Author

MR을 ν•œλ²ˆ 잘λͺ»ν•΄μ„œ Conflict ν•΄κ²°ν•˜κ³  μ˜¬λ ΈμŠ΅λ‹ˆλ‹€.

"
둜또번호 이 ν”Όλ“œλ°±μ€ 반영이 μ•ˆλ˜μ—ˆλ„€μš”!
ν˜Ήμ‹œ 고민의 κ²°κ³Όλ₯Ό λ“€μ–΄λ³Ό 수 μžˆμ„κΉŒμš©? πŸ€”
"

이 뢀뢄에 λŒ€ν•΄μ„œλŠ” λ­”κ°€ 숫자 검증을 ν•˜κΈ°μœ„ν•΄ μ’€ 투머치 ν•˜λ‹€λŠ” λŠλ‚Œμ΄ μžˆμ–΄μ„œ ..? 일단 μœ μ§€λŠ” ν•˜κΈ΄ ν–ˆμŠ΅λ‹ˆλ‹€..

mskangg
mskangg requested changes Apr 7, 2025
View reviewed changes
Copy link

@mskangg mskangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2단계 κ΅¬ν˜„ μž˜ν•΄μ£Όμ…¨λ„€μš”! πŸ‘
λͺ‡κ°€μ§€ ν”Όλ“œλ°± λ‚¨κ²¨λ“œλ ΈλŠ”λ°, ν™•μΈλΆ€νƒλ“œλ¦½λ‹ˆλ‹€ πŸ™‡

@younghooniii
Copy link
Author

리뷰해 μ£Όμ‹  λ‚΄μš© λ°˜μ˜ν–ˆμŠ΅λ‹ˆλ‹€.!

mskangg
mskangg approved these changes Apr 8, 2025
View reviewed changes
Copy link

@mskangg mskangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν”Όλ“œλ°± 반영 κΉ”λ”ν•˜κ²Œ 정말 μž˜ν•΄μ£Όμ…¨λ„€μš”! πŸ‘
μΆ”κ°€λ‘œ μ½”λ©˜νŠΈ λ‚¨κ²¨λ“œλ ΈλŠ”λ°, 이뢀뢄은 λ‹€μŒλ‹¨κ³„ μ§„ν–‰ν•˜μ‹œλ©΄μ„œ λ°˜μ˜λΆ€νƒλ“œλ¦½λ‹ˆλ‹€ πŸ™‡
그럼 λ§ˆμ§€λ§‰λ‹¨κ³„ ν™”μ΄νŒ… πŸ”₯

src/main/java/lotto/domain/LottoPrize.java
Comment on lines +4 to +9
FIRST(6, false, 2_000_000_000),
SECOND(5, true, 30_000_000),
THIRD(5, false, 1_500_000),
FOURTH(4, false, 50_000),
FIFTH(3, false, 5_000),
MISS(0, false, 0);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘
λΉ„μ¦ˆλ‹ˆμŠ€ λ‘œμ§μ„ μ •ν™•νžˆ ν‘œν˜„ν•˜λ €λ©΄, 2등을 μ œμ™Έν•œ λ‚˜λ¨Έμ§€ ν•­λͺ©μ€ λ³΄λ„ˆμŠ€ μ—¬λΆ€κ°€ ν•„μš”ν•˜μ§€ μ•Šμ€ μƒνƒœμ—μš”!
λ³΄λ„ˆμŠ€ μ—¬λΆ€λ₯Ό κ°„κ²°ν•œ ν˜•νƒœμ˜ enum으둜 λ¦¬νŒ©ν† λ§ν•˜λŠ” 것도 쒋은 방법일 것 κ°™μŠ΅λ‹ˆλ‹€.

enum BonusCondition {
    MATCH, 
    MISMATCH, 
    IGNORED;
}

@mskangg mskangg merged commit 6dd93aa into next-step:younghooniii Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskangg mskangg mskangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younghooniii @mskangg