3단계 - 로또(2등) east #4170
Merged
3단계 - 로또(2등) east #4170
+183
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared-moon
approved these changes
Apr 8, 2025
| WinningNumbers winningNumbers = new WinningNumbers(InputView.readWinningNumbers("지난 주 당첨 번호를 입력해 주세요.")); | ||
| String inputWinningNumbers = InputView.readWinningNumbers("지난 주 당첨 번호를 입력해 주세요."); | ||
| int bonusNumber = InputView.readBonusNumber("보너스 볼을 입력해 주세요."); | ||
| WinningNumbers winningNumbers = new WinningNumbers(inputWinningNumbers, bonusNumber); |
| if (Reward.FIRST.matchCount == matchResult.count()) { | ||
| return FIRST; | ||
| } | ||
| if (Reward.SECOND.matchCount == matchResult.count()) { |
There was a problem hiding this comment.
bonusMatch에 대한 정보를 각 enum 객체에서 관리해서 count와 보너스 매칭 여부를 다 판단하던가 SECOND를 먼저 판단하고 SECOND를 제외한 요소들을 순회하면서 원래처럼 카운트 하는 방식으로 바꿔보면 어떨까요 ?
| .map(Reward::valueOf) | ||
| .collect(Collectors.toUnmodifiableList()); | ||
| .collect(Collectors.toUnmodifiableMap(reward -> reward, reward -> 1, Integer::sum)); |
There was a problem hiding this comment.
Collectors.counting() 을 이용해보면 어떨까요 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
위와 같이 나와서 리뷰요청 PR 또 올립니다;;