-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(step3): 자동차 경주 #5332
Open
chyjeon
wants to merge
2
commits into
next-step:chyjeon
Choose a base branch
from
chyjeon:step3
base: chyjeon
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−12
Open
feat(step3): 자동차 경주 #5332
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package racingcar; | ||
|
||
public class Controller { | ||
public void racingGame(){ | ||
InputView inputView = new InputView(); | ||
|
||
int numOfCar = inputView.numberOfCar(); | ||
int numOfTry = inputView.ChanceOfTry(); | ||
} | ||
} |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
package racingcar; | ||
|
||
import java.util.Scanner; | ||
|
||
public class InputView { | ||
|
||
private int numberOfCar; | ||
private int chanceOfTry; | ||
|
||
Scanner scanner = new Scanner(System.in); | ||
|
||
public int numberOfCar(){ | ||
System.out.println("자동차 대수는 몇 대 인가요?\n"); | ||
return scanner.nextInt(); | ||
} | ||
|
||
public int ChanceOfTry(){ | ||
System.out.println("시도할 회수는 몇 회 인가요?\n"); | ||
return scanner.nextInt(); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package racingcar; | ||
|
||
public class OutputView { | ||
public void racingResult(String text){ | ||
System.out.println("실행 결과"); | ||
System.out.println(text); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package racingcar; | ||
|
||
public class RacingCar { | ||
|
||
public static String racingCar(int num){ | ||
if (num == 0) | ||
return ""; | ||
return "num"; | ||
} | ||
} |
Empty file.
Empty file.
Empty file.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package racingcar; | ||
|
||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
|
||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static racingcar.RacingCar.racingCar; | ||
|
||
public class RacingTest { | ||
|
||
|
||
@Test | ||
@DisplayName("자동차 대수 0") | ||
void null_value() { | ||
assertThat(racingCar(0)).isEqualTo(""); | ||
} | ||
} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트가 많이 부족합니다 🙇
만약에 테스트 작성이 어렵다면, 객체들의 역할과 책임이 분명하지 않거나, 비즈니스 로직과 UI로직이 잘 분리가 안되서 그럴 수 있을것 같아요 😄
이 부분 좀 더 개선 고민해주시면 좋을 것 같습니다 🙇