fix(sveltekit) - client functions not working in latest patch #12751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@jaysin586 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
@ThangHuuVu can this be merged to fix sveltekit being broken in the latest version? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
The latest sveltekit changes broke the logging in and out of users when developers attempt to use the client functions.
🧢 Checklist
For tests, I did not know what tooling I could add to update the test cases. I was thinking of using testing-framework jsdom but since they were not in the list of approved packages I did not add any. If there is a link to tools that we can use I will work them into the process.
I am also open to changing it if there is a way to get the baseURL from the server config to the front end. I do not believe this should be hard coded to /auth and should allow the user to change it if necessary. If there is a way we would like to see this implemented I will make any changes required.
🎫 Affected issues
Fixes: #12719
📌 Resources