-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcListItem): Don't require name prop #6128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem, it is used in computedActionsAriaLabel
So let's announce it as primarily used for accessibility, and also as fallback for the |
I'd say, we should just simplify |
So dropping Edit: pushed the mentioned changes. |
0734559
to
deef42b
Compare
deef42b
to
993193e
Compare
6b36f07
to
245116d
Compare
245116d
to
dc1e4af
Compare
7835614
to
ba71cd2
Compare
Targeting master again as there is no breaking change anymore |
Signed-off-by: Louis Chemineau <[email protected]>
ba71cd2
to
a3a2ae5
Compare
/backport to next |
As it is only required if the slot is missing.