Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase OCFileListAdapter Performance #14540

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 11, 2025

  • Tests written, or not not needed

  • Implements DiffUtil

  • Removes mFilesAll

  • Removes unused functions

  • Adds OCFile extensions and removes repeated codes

demo.mp4

@alperozturk96 alperozturk96 linked an issue Feb 11, 2025 that may be closed by this pull request
@alperozturk96 alperozturk96 changed the title Increase File List Adapter Performance Increase OCFileList Adapter Performance Feb 11, 2025
@alperozturk96 alperozturk96 changed the title Increase OCFileList Adapter Performance Increase OCFileListAdapter Performance Feb 12, 2025
@alperozturk96 alperozturk96 force-pushed the increase-file-list-adapter-performance branch from a8d7bf4 to a930e56 Compare February 12, 2025 08:01
alperozturk96 and others added 18 commits February 18, 2025 15:38
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the increase-file-list-adapter-performance branch from 12befbe to 4d9bce1 Compare February 18, 2025 14:39
Signed-off-by: alperozturk <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings5453
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total502502

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14540.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DiffUtil for OCFileListAdapter
1 participant