Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - onSyncFolderSettingsClick ANR #14568

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Fix - onSyncFolderSettingsClick ANR #14568

merged 5 commits into from
Feb 26, 2025
+16 −18

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 21, 2025 •
edited
Loading

  • Tests written, or not not needed

@nextcloud nextcloud deleted a comment from github-actions bot Feb 21, 2025
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.31.0 milestone Feb 24, 2025
@alperozturk96
use lifecycleScope
b1582a3 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
commit transaction
f664b37 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix code analytics
7e30cfe 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
no need add
1740121 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/on-sync-folder-setting-click-anr branch from 20bfa66 to 1740121 Compare February 24, 2025 09:20
@alperozturk96
fix code analytics
b6211e1 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14568.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total502502

@alperozturk96 alperozturk96 removed this from the Nextcloud App 3.31.0 milestone Feb 24, 2025
@tobiasKaminsky tobiasKaminsky merged commit f10ce3e into master Feb 26, 2025
18 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/on-sync-folder-setting-click-anr branch February 26, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom ZetaTom approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @ZetaTom