Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetize Category and Keyword Filters #2416

Closed
wants to merge 0 commits into from

Conversation

nathanielhourt
Copy link

@nathanielhourt nathanielhourt commented Jul 11, 2024

Topic and Scope

In using the Cookbook app, I want to organize my recipes by keywords (often, ingredients) that I find relevant
when searching for recipes to make. I use the Keywords feature for this; however, when filtering by the
keywords, the drop-down list is unsorted by any metric I can comprehend (it's probably sorted by hash value) so
I have difficulty finding the one I'm looking for.

In this PReq, I have alphabetized the Category and Keyword drop-down lists in the recipe lists.

Concerns/issues

It passes tests, and it LGTM in deployment. The change is small; I don't think it should break anything.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (API was not modified)

Copy link

Test Results

   12 files    584 suites   1m 32s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
2 300 runs  2 299 ✅ 1 💤 0 ❌

Results for commit 1482825.

@christianlupus
Copy link
Collaborator

@seyfeb again the question: how to incorporate with the rework?

@seyfeb
Copy link
Collaborator

seyfeb commented Jul 11, 2024

I think it is sensible to have them sorted alphabetically. We need to make sure that does changes carry over to the rework. I'll try to remember that :D

Edit: I just applied sorting to the other branch as well.

@christianlupus
Copy link
Collaborator

This is not ideal as there might be keyword/categories that are only differencing in case (e.g. sweet vs Sweet). These will only appear once in the list now (:+1:) but it is not possible to get all recipes of a certain writing (only sweet) for manual fixing. I see this a feature for the future with the new UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants