feat: update default content #6740
Conversation
Signed-off-by: Luka Trovic <[email protected]>
|
🐢 Performance warning. |
|
could you add some screenshots, to check it out? |
| foreach ($cardsData as $cardData) { | ||
| $stackIndex = $cardData['stackIndex']; | ||
| $defaultCards[] = $this->cardService->create( | ||
| $this->l10n->t($cardData['title']), |
There was a problem hiding this comment.
This won't work. The translations are extracted and then put for translation based on regex matches for the t() method calls, so the strings in the json file would not be found by that.
We should rather have the card title strings defined in PHP directly using the t method calls.
There was a problem hiding this comment.
Maybe we can just have a method that returns a nested array for the board data. That way we can also extend it easily to allow admins providing custom json files with their own demo content
Summary
Add new default content for deck.
Checklist