fix colours in dark mode #7755
Open
fix colours in dark mode #7755
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsding
requested review from
claucambra,
mgallien and
camilasan
and removed request for
claucambra and
mgallien
- use placeholderText for TextField icons (introduced in Qt 5.12) - use windowText for the large icons in activity view/search results - also fix retrieval of icons from the server Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/icons-darkmode
branch
from
42096b4 to
eeb64bc
Compare
|
AppImage file: nextcloud-PR-7755-eeb64bc95ab7dd156b69466dd751a30b32b997a9-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placeholderTextforTextFieldicons (introduced in Qt 5.12 according to https://doc.qt.io/qt-6/qpalette.html#ColorRole-enum)windowTextfor the large icons in activity view/search results(no idea why the icons are missing on the buttons on my Plasma setup, already reported in #7419)