-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recipient info on the right side of the composer #9824
Open
GretaD
wants to merge
35
commits into
main
Choose a base branch
from
enhanc/recipient-info-composer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The raw search query that works <?xml version="1.0"?>
<x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
<x0:prop xmlns:x0="DAV:">
<x0:getcontenttype/>
<x0:getetag/>
<x0:resourcetype/>
<x0:displayname/>
<x0:owner/>
<x0:resourcetype/>
<x0:sync-token/>
<x0:current-user-privilege-set/>
<x0:getcontenttype/>
<x0:getetag/>
<x0:resourcetype/>
<x4:address-data/>
</x0:prop>
<x4:filter test="allof">
<x4:prop-filter name="EMAIL">
<x1:text-match xmlns:x1="urn:ietf:params:xml:ns:carddav">[email protected]</x1:text-match>
</x4:prop-filter>
</x4:filter>
</x4:addressbook-query> |
GretaD
force-pushed
the
enhanc/recipient-info-composer
branch
from
August 21, 2024 13:51
41e2077
to
8673d84
Compare
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
enhanc/recipient-info-composer
branch
from
September 10, 2024 12:41
9d09ecc
to
515402f
Compare
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
This change needs a counterpart in Contacts. Where can we find that change? |
the description was not updated recently, sorry about that, i added the info of the current state. |
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9622
requires: nextcloud/contacts#4194
Note: theres is an issue with closing the minimized button on the bottom right but thats because its an issue with draft not caused by this pr.
There is also a
[Vue warn]: Invalid prop: type check failed for prop "displayName". Expected String, got Undefined.
For the avatar. I will fix that soon. Would be nice to have some reviewers meanwhile.PR description:
When a user is added to the "To" field in the mail composer, a right pane displays the contact details from their profile. Adding a second recipient collapses the list of contact details, with an option to toggle the visibility of the pane to view the data. Clicking the "maximize" button removes the right pane entirely to focus on the composer. Reducing the composer size restores the right pane, making the contact details visible again.
Screencast.from.2024-11-22.14-45-50.mp4