Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recipient info on the right side of the composer #9824

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jul 10, 2024

fixes #9622
requires: nextcloud/contacts#4194

Note: theres is an issue with closing the minimized button on the bottom right but thats because its an issue with draft not caused by this pr.
There is also a[Vue warn]: Invalid prop: type check failed for prop "displayName". Expected String, got Undefined. For the avatar. I will fix that soon. Would be nice to have some reviewers meanwhile.

PR description:
When a user is added to the "To" field in the mail composer, a right pane displays the contact details from their profile. Adding a second recipient collapses the list of contact details, with an option to toggle the visibility of the pane to view the data. Clicking the "maximize" button removes the right pane entirely to focus on the composer. Reducing the composer size restores the right pane, making the contact details visible again.

Screencast.from.2024-11-22.14-45-50.mp4

@GretaD

This comment was marked as outdated.

@ShGKme

This comment was marked as outdated.

@ChristophWurst
Copy link
Member

The raw search query that works

<?xml version="1.0"?>
<x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
  <x0:prop xmlns:x0="DAV:">
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x0:displayname/>
    <x0:owner/>
    <x0:resourcetype/>
    <x0:sync-token/>
    <x0:current-user-privilege-set/>
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x4:address-data/>
  </x0:prop>
  <x4:filter test="allof">
    <x4:prop-filter name="EMAIL">
      <x1:text-match xmlns:x1="urn:ietf:params:xml:ns:carddav">[email protected]</x1:text-match>
    </x4:prop-filter>
  </x4:filter>
</x4:addressbook-query>

@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 41e2077 to 8673d84 Compare August 21, 2024 13:51
@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 9d09ecc to 515402f Compare September 10, 2024 12:41
@ChristophWurst
Copy link
Member

This change needs a counterpart in Contacts. Where can we find that change?

@GretaD
Copy link
Contributor Author

GretaD commented Nov 18, 2024

This change needs a counterpart in Contacts. Where can we find that change?

the description was not updated recently, sorry about that, i added the info of the current state.

@GretaD GretaD marked this pull request as ready for review November 22, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient info next to mail composer
4 participants