add notes path to capabilities

[tobiasKaminsky]

No description provided.

[tobiasKaminsky]

@juliusknorr thanks! Tested & works!

[enjeck]

@tobiasKaminsky Some CI tests are failing

[tobiasKaminsky]

@juliusknorr or @enjeck can you help me with psalm?

ERROR: RiskyTruthyFalsyComparison
at /home/tobi/github/nextcloud/notes/lib/AppInfo/Capabilities.php:29:21
Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
                                'notes_path' => $this->userId ? $this->noteUtil->getNotesFolderUserPath($this->userId) : null,

Not sure what to do.

[enjeck]

I haven't looked deeply yet, but my first thought is that maybe the warning is about $this->userId which could be null or the empty string, and both cases are falsy. So maybe changing to $this->userId !== null && $this->userId !== " "? $this->noteUtil->getNotesFolderUserPath($this->userId) : null

[enjeck]

There seem to be other unrelated CI failures like the test-api (min). I can look into that

[tobiasKaminsky]

@juliusknorr I am sorry, but I give up on this.
I am not familar with it, and having two lines of code changes, killing the entire CI… 🤷

[enjeck]

@tobiasKaminsky At 3b41954, you moved nextcloud/ocp from dev-stable28 to dev-master. I believe that's not required for this PR, so I reverted that in case it was causing some of the CI failures. I can move to dev-master in a separate PR if needed.

[enjeck]

Actually, when I test this out, I get an error on the homepage:

Internal Server Error
The server was unable to complete your request.

If this happens again, please send the technical details below to the server administrator.

More details can be found in the server log.

Technical details
Remote Address: 192.168.21.4
Request ID: 1b5EZixWS2bZK7VIVCVm
Type: OCA\Notes\Service\NotesFolderException
Code: 0
Message: Notes is not a folder
File: /var/www/html/apps/notes/lib/Service/NoteUtil.php
Line: 213

Trace
#0 /var/www/html/apps/notes/lib/Service/NoteUtil.php(189): OCA\Notes\Service\NoteUtil->getOrCreateNotesFolder('admin', false)
#1 /var/www/html/apps/notes/lib/AppInfo/Capabilities.php(29): OCA\Notes\Service\NoteUtil->getNotesFolderUserPath('admin')
#2 /var/www/html/lib/private/CapabilitiesManager.php(61): OCA\Notes\AppInfo\Capabilities->getCapabilities()
#3 /var/www/html/lib/private/Template/JSConfigHelper.php(137): OC\CapabilitiesManager->getCapabilities(false, true)
#4 /var/www/html/lib/private/TemplateLayout.php(239): OC\Template\JSConfigHelper->getConfig()
#5 /var/www/html/lib/private/legacy/OC_Template.php(120): OC\TemplateLayout->__construct('user', 'dashboard')
#6 /var/www/html/lib/public/AppFramework/Http/TemplateResponse.php(189): OC_Template->fetchPage(Array)
#7 /var/www/html/lib/private/AppFramework/Http/Dispatcher.php(159): OCP\AppFramework\Http\TemplateResponse->render()
#8 /var/www/html/lib/private/AppFramework/App.php(161): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Dashboard\Controller\DashboardController), 'index')
#9 /var/www/html/lib/private/Route/Router.php(306): OC\AppFramework\App::main('OCA\\Dashboard\\C...', 'index', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#10 /var/www/html/lib/base.php(1018): OC\Route\Router->match('/apps/dashboard...')
#11 /var/www/html/index.php(24): OC::handleRequest()
#12 {main}

Probably shouldn't have merged yet???

[enjeck]

@tobiasKaminsky At 3b41954, you moved nextcloud/ocp from dev-stable28 to dev-master. I believe that's not required for this PR, so I reverted that in case it was causing some of the CI failures. I can move to dev-master in a separate PR if needed.

I suspect that 3b41954 is essential and I shouldn't have removed it 🤦

[enjeck]

I tried using dev-master (which required going from php 8.0 to 8.1) but that didn't help

[blizzz]

This is probably on users where the folder does not exists yet (e.g. new users on first login).
Possible solutions: either the create parameter has to be true, or the NotesFolderException has to be caught.

[blizzz]

An integration test would have caught this btw.

[enjeck]

Even a frontend test would have caught this too, since this error crashes the entire server 🤦