Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch exception when getting notes folder #1486

Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix: catch exception when getting notes folder #1486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a041a
fix: catch exception when getting notes folder
enjeck Feb 19, 2025
2385a9b
refactor: Use warning instead of error
enjeck Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/Service/NoteUtil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,12 @@ public function getOrCreateFolder(string $path, bool $create = true) : Folder {
public function getNotesFolderUserPath(string $userId): ?string {
/** @psalm-suppress MissingDependency */
$userFolder = $this->getRoot()->getUserFolder($userId);
$nodesFolder = $this->getOrCreateNotesFolder($userId, false);
try {
$nodesFolder = $this->getOrCreateNotesFolder($userId, false);
} catch (NotesFolderException $e) {
$this->util->logger->warning("Failed to get notes folder for user $userId: " . $e->getMessage());
return null;
}
return $userFolder->getRelativePath($nodesFolder->getPath());
}

Expand Down