fix: send etag for settings URLs and update etag on file changes #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codewithvk
force-pushed
the
private/codewithvk/caching
branch
2 times, most recently
from
15d3388 to
7456073
Compare
- Replace timestamp with the folder etag in settings generation. - Update the folder etag when files are created or deleted. - Refactor folder retrieval logic into helper methods for consistency. Signed-off-by: codewithvk <[email protected]>
codewithvk
force-pushed
the
private/codewithvk/caching
branch
2 times, most recently
from
e043aa0 to
723eca0
Compare
codewithvk
force-pushed
the
private/codewithvk/caching
branch
from
723eca0 to
514e3e0
Compare
Signed-off-by: codewithvk <[email protected]>
codewithvk
force-pushed
the
private/codewithvk/caching
branch
from
514e3e0 to
c9b774d
Compare
elzody
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: send etag for settings URLs and update etag on file changes
Checklist