feat(theming): allow to disable standalone windows

Signed-off-by: Simon L. <[email protected]>
nextcloud · Feb 5, 2025 · c12f3c8 · c12f3c8
1 parent 1407a1d
commit c12f3c8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php
@@ -454,6 +454,7 @@ public function getManifest(string $app): JSONResponse {
 				$startUrl = $this->urlGenerator->getBaseUrl() . '/apps/' . $app . '/';
 			}
 			$description = $info['summary'] ?? '';
+			$displayMode = $this->config->getSystemValueBool('theming.standalone_window.enabled', true) ? 'standalone' : 'browser';
 		}
 		/**
 		 * @var string $description
@@ -481,7 +482,7 @@ public function getManifest(string $app): JSONResponse {
 						'sizes' => '16x16'
 					]
 				],
-			'display' => 'standalone'
+			'display' => $displayMode
 		];
 		$response = new JSONResponse($responseJS);
 		$response->cacheFor(3600);

diff --git a/apps/theming/tests/Controller/ThemingControllerTest.php b/apps/theming/tests/Controller/ThemingControllerTest.php
@@ -734,6 +734,11 @@ public function testGetManifest(): void {
 				['theming.Icon.getTouchIcon', ['app' => 'core'], 'touchicon'],
 				['theming.Icon.getFavicon', ['app' => 'core'], 'favicon'],
 			]);
+		$this->config
+			->expects($this->once())
+			->method('getSystemValueBool')
+			->with('theming.standalone_window.enabled', true)
+			->willReturn(true);
 		$response = new JSONResponse([
 			'name' => 'Nextcloud',
 			'start_url' => 'localhost',

diff --git a/config/config.sample.php b/config/config.sample.php
@@ -2129,6 +2129,14 @@
  */
 'enforce_theme' => '',
 
+
+/**
+ * This setting allows to disable the PWA functionality that allows browsers to open web applications in dedicated windows.
+ *
+ * Defaults to ``true``
+ */
+'theming.standalone_window.enabled' => true,
+
 /**
  * The default cipher for encrypting files. Currently supported are:
  *  - AES-256-CTR