-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not prevent subfolder uploads if same file exists in current direc… #3382
Conversation
@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @luckydonald and @vincchan to be potential reviewers. |
cc @nextcloud/javascript |
This @mention-bot keeps mentioning me, even thus I have blocked him. This is kinda annoying. |
Yep - also the user blacklist is broken :/ See facebookarchive/mention-bot#178 - maybe raise your voice there too |
So reading owncloud/core#26434, currently the blacklist file isn't working either? |
Sadly yes 😞 |
a25d019
to
892660d
Compare
Can't wrap my head around those unit tests. Some black hackery is going on there. @nextcloud/javascript if someone likes challenges, please take a look 😉🚀 |
@danxuliu Could you help here with the tests as well? 😃 |
…tory Signed-off-by: Christoph Wurst <[email protected]>
892660d
to
9df718d
Compare
Rebased |
Codecov Report
@@ Coverage Diff @@
## master #3382 +/- ##
============================================
+ Coverage 52.82% 54.05% +1.22%
+ Complexity 22802 21052 -1750
============================================
Files 1442 1245 -197
Lines 88562 73344 -15218
Branches 1349 0 -1349
============================================
- Hits 46787 39648 -7139
+ Misses 41775 33696 -8079
|
@danxuliu If you have time to look at this: feel free to re-open it. Let's close this for now nevertheless. |
raising back the dead |
obsoleted by #28250 |
…tory
@MorrisJobke some js tests are failing, but I'm unsure if they should even pass. For example
server/apps/files/tests/js/fileUploadSpec.js
Lines 164 to 187 in fa96b9e
fixes #1218