Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: template field title #50602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: template field title #50602

wants to merge 1 commit into from

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jan 31, 2025 •
edited
Loading

⚠️ Tests are implemented in nextcloud/richdocuments#4448

Screenshots

Before

image

After

image

Checklist

@elzody elzody added the 3. to review Waiting for reviews label Jan 31, 2025
@elzody elzody self-assigned this Jan 31, 2025
@juliusknorr
Copy link
Member

Would it make sense to rather hide them? If they are not labeled, probably nobody would know what to insert

@elzody elzody marked this pull request as draft February 4, 2025 23:54
@elzody elzody added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 4, 2025
@elzody elzody force-pushed the fix/template-field-title branch from d19be02 to ae69f09 Compare February 6, 2025 16:44
@elzody elzody force-pushed the fix/template-field-title branch from ae69f09 to 7c15fc6 Compare February 7, 2025 19:36
@elzody elzody mentioned this pull request Feb 7, 2025
Open
@elzody elzody marked this pull request as ready for review February 7, 2025 19:49
@elzody elzody added 3. to review Waiting for reviews feature: templates and removed 2. developing Work in progress labels Feb 7, 2025
@elzody
Copy link
Contributor Author

elzody commented Feb 7, 2025

/backport to stable31

@elzody
Copy link
Contributor Author

elzody commented Feb 7, 2025

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@elzody elzody

Labels
3. to review Waiting for reviews backport-request feature: templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Create templates with fields is shown even if fields have no title
2 participants
@elzody @juliusknorr