Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repair): PHP8.3 deprecation warning #50809

Merged
merged 1 commit into from
Feb 15, 2025
Merged

fix(repair): PHP8.3 deprecation warning #50809

merged 1 commit into from
Feb 15, 2025
+4 −8

Conversation

solracsf
Copy link
Member

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Feb 14, 2025
@solracsf solracsf added this to the Nextcloud 32 milestone Feb 14, 2025
@solracsf solracsf force-pushed the fixPhp83Deprecation branch from e45d597 to 8851757 Compare February 14, 2025 10:55
@solracsf solracsf requested review from susnux and artonge February 14, 2025 10:55
joshtrichards
joshtrichards approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised tests didn't catch this in #50193.

@joshtrichards
Copy link
Member

/backport to stable31

@joshtrichards
Copy link
Member

/backport to stable30

@joshtrichards
Copy link
Member

/backport to stable29

@solracsf solracsf enabled auto-merge February 14, 2025 16:59
@solracsf solracsf requested a review from st3iny February 14, 2025 17:29
st3iny
st3iny approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad. Thanks for the fix :)

@solracsf solracsf merged commit b9f8539 into master Feb 15, 2025
189 checks passed
@solracsf solracsf deleted the fixPhp83Deprecation branch February 15, 2025 11:06
This was referenced Feb 15, 2025
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@joshtrichards joshtrichards joshtrichards approved these changes

@susnux susnux Awaiting requested review from susnux

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

Php Error: String in var deprecation
3 participants
@solracsf @joshtrichards @st3iny