Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate from vuex to pinia #1540

Merged
merged 3 commits into from
Jan 29, 2025
Merged

feat: migrate from vuex to pinia #1540

merged 3 commits into from
Jan 29, 2025

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jan 13, 2025

fixes #1492

@enjeck enjeck self-assigned this Jan 13, 2025
nfebe
nfebe reviewed Jan 18, 2025
View reviewed changes
Copy link

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@enjeck enjeck force-pushed the pinea branch 2 times, most recently from 54a3d9c to 9b7249a Compare January 20, 2025 08:23
@enjeck enjeck marked this pull request as ready for review January 21, 2025 08:05
@enjeck enjeck requested a review from blizzz as a code owner January 21, 2025 08:05
@enjeck enjeck requested a review from juliusknorr January 21, 2025 08:06
@enjeck
Copy link
Contributor Author

enjeck commented Jan 21, 2025 •
edited
Loading

TODO:

  • fix context navigation display. Doesn't work when I test manually, but we have no automated tests to catch this

@enjeck
Copy link
Contributor Author

enjeck commented Jan 22, 2025 •
edited
Loading

TODO:

  • fix context navigation display. Doesn't work when I test manually, but we have no automated tests to catch this

Now fixed. Automated tests being written at #1553

  • Manually test smartpicker

enjeck added 3 commits January 26, 2025 18:49
@enjeck
feat: migrate from vuex to pinia
43fe7ba 
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
@enjeck
fix: properly call store functions
da98b5c 
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
@enjeck
fix: rename context functions to avoid conflicts
e2faffc 
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
@juliusknorr juliusknorr requested a review from grnd-alt January 27, 2025 20:59
@juliusknorr
Copy link
Member

While testing i found some frequent console error when navigating between tables, but something separate as it also happens on main, but should be fixed. Is that known/tracked somwhere?

Screenshot 2025-01-29 at 07 06 40

@enjeck
Copy link
Contributor Author

enjeck commented Jan 29, 2025

Is that known/tracked somwhere?

I believe it's related to #1477. I'll take a look

@juliusknorr juliusknorr merged commit 2d99f7d into main Jan 29, 2025
47 checks passed
@juliusknorr juliusknorr deleted the pinea branch January 29, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

@grnd-alt grnd-alt Awaiting requested review from grnd-alt

Assignees

@enjeck enjeck

Labels
None yet
Projects
📝 Office team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from vuex to pinia
3 participants
@enjeck @juliusknorr @nfebe