Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap usergroup's cell values #1551

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: wrap usergroup's cell values #1551

merged 1 commit into from
Jan 23, 2025

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jan 20, 2025

We need to wrap the container of usergroup items. Otherwise, they overflow the container when there are too many items.

Before

Screenshot from 2025-01-20 18-11-57

After

Screenshot from 2025-01-20 18-18-56

@enjeck enjeck added the bug Something isn't working label Jan 20, 2025
@enjeck enjeck requested a review from juliusknorr January 20, 2025 18:43
@enjeck enjeck self-assigned this Jan 20, 2025
@enjeck enjeck requested a review from blizzz as a code owner January 20, 2025 18:43
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
@blizzz blizzz merged commit 721a597 into main Jan 23, 2025
47 checks passed
@blizzz blizzz deleted the ug-bubble-wrap branch January 23, 2025 20:27
@enjeck
Copy link
Contributor Author

enjeck commented Jan 28, 2025

/backport to stable0.8

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 28, 2025
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jan 28, 2025
@Ornanovitch
Copy link

Nice :)

But why not using a global rule in order to harmonize this behavior across the app and fix also #974?

And what if you have 100 users in the cell? A "click to see more" would be ideal.

@enjeck
Copy link
Contributor Author

enjeck commented Jan 28, 2025

But why not using a global rule in order to harmonize this behavior across the app and fix also #974?

And what if you have 100 users in the cell? A "click to see more" would be ideal.

This is a good point that I didn't think about, thanks. We should consider having a "see more" button for all column types when working on #974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants