Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display label in the placeholder #4703

Merged
merged 6 commits into from
Feb 17, 2025
Merged

display label in the placeholder #4703

merged 6 commits into from
Feb 17, 2025

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Feb 7, 2025 •
edited
Loading

Resolve #4672

  • General placeholder support for mentions

🖼️ Screenshots

🏚️ Before 🏡 After
without_placeholder with placeholder

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review February 7, 2025 17:32
@sowjanyakch sowjanyakch self-assigned this Feb 7, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 7, 2025
@sowjanyakch sowjanyakch force-pushed the fix_placeholder_support branch from c76d51a to e4f44dd Compare February 10, 2025 14:15
@sowjanyakch sowjanyakch force-pushed the fix_placeholder_support branch from e4f44dd to 022785c Compare February 14, 2025 08:28
@sowjanyakch
display label in the placeholder
1ad186b 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
format code
a133804 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
label styling
f418955 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch force-pushed the fix_placeholder_support branch from 022785c to f418955 Compare February 17, 2025 12:09
@mahibi
Copy link
Collaborator

mahibi commented Feb 17, 2025 •
edited
Loading

method processMessageParameters is too long (must be <=60 for detekt to pass)

@sowjanyakch
fix detekt
edcadbc 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
remove unused constant
ea60878 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
ktlintFormat
80e98a0 
Signed-off-by: sowjanyakch <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4703-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@sowjanyakch sowjanyakch merged commit b3186ba into master Feb 17, 2025
16 checks passed
@sowjanyakch sowjanyakch deleted the fix_placeholder_support branch February 17, 2025 15:56
@sowjanyakch
Copy link
Contributor Author

/backport to stable-21.0

@backportbot backportbot bot mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circles / Teams support
3 participants
@sowjanyakch @mahibi @nickvergessen