Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing mentions disappearing #4705

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixing mentions disappearing #4705

wants to merge 4 commits into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Feb 10, 2025 •
edited
Loading 

12:17:27.525  D  S:1 E:14
12:17:28.735  D  S:1 E:14
12:17:28.901  D  S:1 E:14
12:17:30.256  D  S:1 E:14
12:17:30.415  D  S:1 E:14
12:17:31.635  D  S:1 E:14
12:17:32.234  D  S:0 E:23
12:17:32.235  D  What:  Julius Linus2 will it 
12:17:32.235  D  MentionSpan removed: Spans.MentionChipSpan([email protected], label=Julius Linus2)

Didn't figure out whats causing it, but implemented a work around instead. In the future, this feature should be reimplemented without the library, for better control over the span handling.

🚧 TODO

  • Figure out why the mention span length is getting reset to include the entire message
  • Try to dynamically detect and correct the error.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004
found the error
4feac1c 
Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 added bug Something isn't working 2. developing Work in progress labels Feb 10, 2025
@rapterjet2004 rapterjet2004 self-assigned this Feb 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4705-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@rapterjet2004 rapterjet2004 marked this pull request as ready for review February 13, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

At least 1 approving review is required to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels
2. developing Work in progress bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mention get lost while composing message
1 participant
@rapterjet2004