Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/noid/improve contacts activity design #4740

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Bugfix/noid/improve contacts activity design #4740

merged 4 commits into from
Feb 18, 2025
+20 −6

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Feb 18, 2025

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20250218_114206 Screenshot_20250218_133920
🏚️ Before 🏡 After
grafik grafik
🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Feb 18, 2025
@mahibi mahibi added this to the 21.1.0 milestone Feb 18, 2025
@mahibi mahibi self-assigned this Feb 18, 2025
@mahibi
Copy link
Collaborator Author

mahibi commented Feb 18, 2025

/backport to stable-21.0

@sowjanyakch sowjanyakch force-pushed the bugfix/noid/improveContactsActivityDesign branch from 83ff7a5 to c5517c8 Compare February 18, 2025 13:55
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4740-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@sowjanyakch sowjanyakch merged commit e648b88 into master Feb 18, 2025
18 checks passed
@sowjanyakch sowjanyakch deleted the bugfix/noid/improveContactsActivityDesign branch February 18, 2025 16:39
@backportbot backportbot bot mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mahibi @sowjanyakch