fix issue #4 - units not displayed properly

nextdoorpanda · Sep 11, 2023 · 0cfd8f9 · 0cfd8f9
1 parent 6676978
commit 0cfd8f9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/assets/js/ci-openweather.js b/assets/js/ci-openweather.js
@@ -45,9 +45,11 @@
         const weatherIconCode = weatherData.list[0].weather[0].icon;
         const weatherIcon = `http://openweathermap.org/img/w/${weatherIconCode}.png`;
         const weatherTemperatureValue = `${parseInt(weatherData.list[0].main.temp)}`;
-        let weatherTemperatureDegree = 'K';
-        weatherOptionsValues.unit = 'metric' ? weatherTemperatureDegree = '&deg;C' : weatherTemperatureDegree = '&deg;F';
-        const weatherTemperature = `${weatherTemperatureValue}${weatherTemperatureDegree}`;
+        const weatherTemperatureDegrees = [{'standard': 'K'}, {'metric': 'C'}, {'imperial': 'F'}];
+        const weatherTemperatureDegree = weatherTemperatureDegrees
+            .filter( obj => weatherOptionsValues.unit in obj)
+            .map(obj => obj[weatherOptionsValues.unit]);
+        const weatherTemperature = `${weatherTemperatureValue}&deg;${weatherTemperatureDegree}`;
 
         const outputDiv = document.querySelectorAll('.weather-output');
         outputDiv.forEach( item => {