Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend observer with onFileStage #5907

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rcannood
Copy link
Contributor

Closes #5905

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit acd641a
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67dd2f4bbf42a300087d8f32

Signed-off-by: Robrecht Cannoodt <[email protected]>
@bentsherman
Copy link
Member

Before we go down this road, we should see if we can simply preserve the remote path here:

Then you should be able to use the onProcessPending event in the trace observer to get the original path via handler.task.inputs. That would be preferable to adding a new trace event

Signed-off-by: Robrecht Cannoodt <[email protected]>
@rcannood
Copy link
Contributor Author

Before we go down this road, we should see if we can simply preserve the remote path here:

Added to #5911 -- not sure whether this is what you had in mind.

Having said that, I wonder whether adding this function to the observer isn't also just a good addition, because it would make it super clear from the documentation how to get observe staging events.

@rcannood rcannood requested a review from a team as a code owner March 21, 2025 09:18
Signed-off-by: Robrecht Cannoodt <[email protected]>
Signed-off-by: Robrecht Cannoodt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect when files are being staged
2 participants