nf-lang: Add type checking utils #5913
Conversation
bentsherman
commented
Mar 21, 2025
bentsherman
commented
- Add basic type checking utilities from language server
- Cleanup implicit declaration analysis
- Cleanup process/workflow output name checking
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
@pditommaso it looks like I still can't merge without at least 1 approval, even though this PR is contained within nf-lang. It requests a review from @nextflow-io/lang as code owner, but I still can't merge without approval and I can't approve my own PR. So it seems like being a code owner doesn't actually give me permission to push to master |
|
Regardless of unit tests, I should be able to merge this PR without approval because it is only touching nf-lang |
|
If you are in hurry, I can merge this, however remain a good practice in include tests new or existing components. I understand this is impacting existing functionality, but it will at some points. |
|
Putting the tests aside for a moment, you shouldn't have to approve/merge this at all. I should be able to do it myself since it only touches nf-lang |
|
I think one approver requires someone different from the PR creator, irrespective of module ownership |
|
Yeah I can't approve my own PR even though I'm a code owner. We might need to make some exception, either for my username or for the lang team. Not sure what options are available in the settings |
|
At this point, make more sense get rid of the "lang" team and include more approvers in the pr |
|
Yeah it seems like the code owners thing isn't doing anything for us. But I need to be able to update nf-lang without approval for the time being. That was one of my requirements for moving nf-lang into the nextflow repo |
|
You should be able to merge now |
|
Thanks. I will add some unit tests in a separate PR |
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
