-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebrand nf-validation to nf-schema #1
Changes from 4 commits
4e5472c
2b16bd2
cc3edf7
0ed3d2b
de05387
2e998c4
49ddc29
7bbd2e6
c0d16eb
e892555
2886e1e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# nextflow-io/nf-validation: Changelog | ||
# nextflow-io/nf-schema: Changelog | ||
|
||
# Version 2.0.0 - Kagoshima | ||
|
||
|
nvnieuwk marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needs replacing and renaming I think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, I'm not sure how to make this logo (@mirpedrol you made it, right?) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I will push a new image with the new name. We should also think of a new logo later. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done! The check mark doesn't make a lot of sense now, do you have better ideas? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe the icon without the check mark? It kinda looks like schemafile |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,12 +9,12 @@ hide: | |
You can see an example JSON Schema for a Nextflow pipeline `nextflow_schema.json` file below. | ||
|
||
This file was generated from the nf-core pipeline template, using `nf-core create`. | ||
It is used as a test fixture in the nf-validation package [here](https://github.com/nextflow-io/nf-validation/blob/master/plugins/nf-validation/src/testResources/nextflow_schema.json). | ||
It is used as a test fixture in the nf-schema package [here](https://github.com/nextflow-io/nf-schema/master/plugins/nf-schema/resources/nextflow_schema.json). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sure about that url? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah missed another one 😁 Thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although no it's the correct one. (It works when I view it using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All look ok to me for this PR, except this line, but if you say it's ok, it's a ✔️ from me |
||
|
||
!!! note | ||
|
||
More examples can be found in the plugin [`testResources` directory](https://github.com/nextflow-io/nf-validation/blob/master/plugins/nf-validation/src/testResources/). | ||
More examples can be found in the plugin [`testResources` directory](https://github.com/nextflow-io/nf-schema/master/plugins/nf-schema/testResources/). | ||
|
||
```json | ||
--8<-- "plugins/nf-validation/src/testResources/nextflow_schema.json" | ||
--8<-- "plugins/nf-schema/src/testResources/nextflow_schema.json" | ||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
plugins { | ||
id 'nf-validation@2.0.0' | ||
id 'nf-schema@2.0.0' | ||
} | ||
|
||
params { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
plugins { | ||
id 'nf-validation@2.0.0' | ||
id 'nf-schema@2.0.0' | ||
} | ||
|
||
params { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
plugins { | ||
id 'nf-[email protected].0' | ||
id 'nf-schema.0' | ||
nvnieuwk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
params { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
plugins { | ||
id 'nf-validation@2.0.0' | ||
id 'nf-schema@2.0.0' | ||
} | ||
|
||
params { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
src/
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot!!!