Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the cyclomatic complexity of the order fulfillment app #41

Merged
merged 2 commits into from
May 6, 2024

Conversation

muellerd
Copy link
Contributor

@muellerd muellerd commented May 2, 2024

This PR reduces the cyclomatic complexity of the order fulfillment app and adjusts the golangcI-lint config file.

Copy link
Member

@sebastian-quintero sebastian-quintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG Amazing

@muellerd
Copy link
Contributor Author

muellerd commented May 6, 2024

@sebastian-quintero The readme-test has been hanging since Friday. Is there a way to fix this?

@nilsbeck nilsbeck marked this pull request as draft May 6, 2024 09:18
@nilsbeck nilsbeck marked this pull request as ready for review May 6, 2024 09:18
@nilsbeck
Copy link
Contributor

nilsbeck commented May 6, 2024

@sebastian-quintero The readme-test has been hanging since Friday. Is there a way to fix this?

I fixed that for you. -> put back to draft, then back in review.

@muellerd muellerd merged commit 4318cf3 into develop May 6, 2024
29 checks passed
@muellerd muellerd deleted the chore/eng-1809-reduce-cyclomatic-complexity branch May 6, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants