New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two-phase SQL rewrites #687

Merged

hrach merged 3 commits into main from rewrites-two-phase

Oct 31, 2024

Member

hrach commented Oct 29, 2024 •

edited

Loading

It's kinda funny how this change looks simple. It took me 5 hours to come up with it
🤯💥🤯💥🤯💥🤯💥🤯💥🤯💥

hrach commented

View reviewed changes

tests/cases/integration/Relationships/relationships.oneHasMany.phpt Show resolved Hide resolved

hrach linked an issue

that may be closed by this pull request

Performance issues in simpley ANY queries with or. #686

Closed

hrach self-assigned this

hrach added this to the v5.0 milestone

hrach force-pushed the rewrites-two-phase branch from 4402b54 to dedc0ba Compare

October 29, 2024 22:33

hrach commented

View reviewed changes

src/Collection/Functions/BaseCompareFunction.php Outdated Show resolved Hide resolved

hrach commented

View reviewed changes

src/Collection/Functions/Result/DbalExpressionResult.php Show resolved Hide resolved

hrach commented

View reviewed changes

src/Collection/Functions/Result/DbalExpressionResult.php Outdated Show resolved Hide resolved

hrach commented

View reviewed changes

src/Collection/Functions/Result/DbalExpressionResult.php Outdated Show resolved Hide resolved

hrach mentioned this pull request

separate WHERE & HAVING in expression result & fix buggy having rewrite #685

Merged

hrach force-pushed the rewrites-two-phase branch from dedc0ba to ee8b661 Compare

October 30, 2024 20:02

hrach linked an issue

that may be closed by this pull request

Missing primary filter lifting to HAVING clause #690

Closed

hrach mentioned this pull request

Missing primary filter lifting to HAVING clause #690

Closed

hrach added 2 commits

October 31, 2024 10:42


          add ignore for Orm 4.0 branch testing setup files

4375d6b


          drop QueryBuilder parameter for dbal aggregation

67e14dc

hrach force-pushed the rewrites-two-phase branch from ee8b661 to a026c48 Compare

October 31, 2024 10:29


          rework collection functions to utilize two-phase expression processing

ad6dfe0

To provide more smarted SQL rewrites, we need to know if the expression
itself is in AND/OR junction and if other parts of the junction
require a HAVING clause. This is possible only after getting the full
expression tree. Then we collect the actual expressions.

[closes #690]
[closes #686]

hrach force-pushed the rewrites-two-phase branch from a026c48 to ad6dfe0 Compare

October 31, 2024 10:35

hrach merged commit 43e6322 into main

8 checks passed

hrach deleted the rewrites-two-phase branch

October 31, 2024 10:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet