Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger_rebuild_pipeline: Update inputs to match ncov builds #442

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Mar 6, 2024

The inputs required to trigger downstream ncov builds were originally set in Nov 2022 (80e5384).

The downstream ncov builds have since been updated to use different input files from S3 in April 2023:

  1. use aligned.fasta instead of sequences.fasta
  2. use zst instead of gz/xz files
  3. 21L inputs were updated to aligned.fasta and zst files

This commit updates the inputs for the trigger rule to ensure that the downstream ncov builds are only triggered after the appropriate files have been uploaded to S3.

[1] nextstrain/ncov@1376d82
[2] nextstrain/ncov@ad0d1e3
[3] nextstrain/ncov@2323afd

Checklist

  • Checks pass

The inputs required to trigger downstream ncov builds were originally
set in Nov 2022 (80e5384).

The downstream ncov builds have since been updated to use different
input files from S3 in April 2023:
1. use aligned.fasta instead of sequences.fasta
2. use zst instead of gz/xz files
3. 21L inputs were updated to aligned.fasta and zst files

This commit updates the inputs for the trigger rule to ensure that the
downstream ncov builds are only triggered after the appropriate files
have been uploaded to S3.

[1] nextstrain/ncov@1376d82
[2] nextstrain/ncov@ad0d1e3
[3] nextstrain/ncov@2323afd
@joverlee521 joverlee521 requested a review from a team March 6, 2024 18:47
@joverlee521
Copy link
Contributor Author

Merging without review since the local dry runs are able to create DAG with updated inputs

$ nextstrain build . --configfile config/gisaid.yaml --config trigger_rebuild=True -n
...
Job 79: Triggering nextstrain/ncov rebuild action (via repository dispatch)
Reason: Missing output files: data/genbank/trigger-rebuild.done; Input files updated by another job: data/genbank/metadata.tsv.zst.upload, data/genbank/aligned.fasta.zst.upload

@joverlee521 joverlee521 merged commit 1d3a131 into master Mar 6, 2024
1 check passed
@joverlee521 joverlee521 deleted the update-trigger-rebuild branch March 6, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant