Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated dengue lineages dataset #227

Merged
merged 6 commits into from
Oct 16, 2024
Merged

updated dengue lineages dataset #227

merged 6 commits into from
Oct 16, 2024

Conversation

jamessiqueirap
Copy link
Contributor

No description provided.

@jamessiqueirap jamessiqueirap changed the title Correct potential subassignment errors updated dengue lineages dataset Sep 10, 2024
corneliusroemer
corneliusroemer requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to change the CHANGELOG (add instead of replace)

You can test the new dataset like this:

https://master.clades.nextstrain.org/?dataset-url=gh:jamessiqueirap/dengue-lineages-dataset@master@data/community/v-gen-lab/dengue/denv1

(replace dev1 with denv2 for the other datasets of course)

data/community/v-gen-lab/dengue/denv1/CHANGELOG.md Show resolved Hide resolved
data/community/v-gen-lab/dengue/denv1/CHANGELOG.md Outdated Show resolved Hide resolved
corneliusroemer
corneliusroemer approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is great now! Sorry for the delay in approval and merging, do please ping me in the future if I take too long!

@corneliusroemer corneliusroemer merged commit b5e8f78 into nextstrain:master Oct 16, 2024
1 check passed
@ivan-aksamentov
Copy link
Member

The new datasets have been released and are available for all Nextclade users https://github.com/nextstrain/nextclade_data/releases/tag/2024-10-17--16-48-48Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusroemer corneliusroemer corneliusroemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamessiqueirap @ivan-aksamentov @corneliusroemer