-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mpox datasets #243
Update mpox datasets #243
Conversation
I accidentally duplicated the changelog in the most recent sars-cov-2 release and this commit undoing it seems to break CI: 7ecaf24 Making a new release to fix - any other ideas what we could do @ivan-aksamentov? |
@corneliusroemer There is no automated mechanism to modify released data, as it is meant to be immutable. This have to be done manually on S3 (perhaps you could modify things on GitHub and then use the prod scripts to reupload). But in this case there's a real chance to introduce breakage to prod, loose data etc. I'd say it isn't worth it. Another thing is that it is cached for a very long time in the browsers, so people who already loaded the dataset once won't see the fix pretty much for a year. But if you insist I could try next week. Otherwise, I propose you revert 7ecaf24 and proceed as if nothing happened. This should not affect mpox dataset. You can treat them as independent in this situation. |
So I can't clean up the changelog for the future? Shouldn't it work like it is now on this PR? We're not changing previously released datasets, just SARS-CoV-2 in the future? |
I think you can. Next time when adding a new It won't clean the duplicates from the old dataset on S3 and from browser caches. So this way we will end up with a single version which have duplicates - which is not a big deal I think. |
The reason the script failed with Adding a new unreleased section (now or during the future release) will allow the script to proceed. |
Yeah I'm fine with mostly a dummy release that just fixes the changelog - not too bad overall I think. I'll just double check for non-duplicate changelog entries in the future. |
Also fix duplicate changelog entries for SC2 through new release as otherwise deployment fails