Skip to content

Commit

Permalink
aws/cognito: Extend validity of the CLI's refresh tokens from 30 → 90…
Browse files Browse the repository at this point in the history
… days

In practice, 30 days seems too short.

I've observed users who get the CLI installed and logged in but then
don't get to uploading their datasets until more than 30 days later
(i.e. they spend time producing the datasets or on other work) and so
then have to log in again when it's time to upload.  This has been a
minor frustration and stumbling block for them.

In a different use case, @corneliusroemer has also found 30 days to be
too short in automation contexts.  Although I'd suggest a different
approach for automation¹, I suspect his approach will not be an uncommon
one for users to take so we should ensure it's not too onerous when they
do.

Resolves <nextstrain/cli#337>.

¹ <nextstrain/cli#337 (comment)>
  • Loading branch information
tsibley committed Jan 9, 2024
1 parent c3dd726 commit c675c6b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion aws/cognito/clients.tf
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ resource "aws_cognito_user_pool_client" "nextstrain-cli" {
# Token lifetimes dictate background refresh (and re-login) rates for the CLI.
id_token_validity = 60
access_token_validity = 60
refresh_token_validity = 30
refresh_token_validity = 90
token_validity_units {
access_token = "minutes"
id_token = "minutes"
Expand Down

0 comments on commit c675c6b

Please sign in to comment.