Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize phylogenetic build [#2] #9

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Modernize phylogenetic build [#2] #9

merged 9 commits into from
Jul 31, 2024

Conversation

genehack
Copy link
Contributor

@genehack genehack commented Jul 18, 2024

Description of proposed changes

Updates yellow-fever phylo build to match pathogen-repo-guide standard.

Also updates various ingest curation steps to use augur curate instead of vendored ingest scripts.

Related issue(s)

#2 #8

Checklist

  • Checks pass

Copy link

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed workflow bits only, will leave scientific review to others.

phylogenetic/rules/prepare_sequences.smk Show resolved Hide resolved
ingest/rules/curate.smk Show resolved Hide resolved
ingest/Snakefile Show resolved Hide resolved
* Update template files to remove instructions and placeholders
* Add Genbank and GFF references
* Bring in phylo workflow from pathogen-repo-guide and modify to work
Also remove exclusion from .pre-commit-config.yaml
* Drop to Python 3.11 in GitHub pre-commit CI, to match actual
  development practice
* Clean up formatting of several files
* Convert all Markdown links to use reference dictionary at end of
  file
* Add `log` and `benchmark` to all Snakemake rules that didn't have
  them
* Remove `dump_ncbi_dataset_report` rule
Also adds logging redirects everywhere
subrepo:
  subdir:   "ingest/vendored"
  merged:   "980c010"
upstream:
  origin:   "https://github.com/nextstrain/ingest"
  branch:   "main"
  commit:   "258ab8c"
git-subrepo:
  version:  "0.4.7"
  origin:   "https://github.com/ingydotnet/git-subrepo/"
  commit:   "c9ec2a6"
* Switch Auspice to default color-by=region
* Remove extra `metadata_columns` (and associated config) when calling
  `augur export v2`
* Move `--columns` arg of `augur traits` into config
* Add `--metadata-id-columns` arg to `augur traits` invocation --
  fixes issue where traits were being improperly inferred
* Use a mid-point tree rooting
@genehack genehack merged commit ff682b1 into main Jul 31, 2024
1 check passed
@genehack genehack deleted the phylogenetic-2 branch July 31, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants