-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize phylogenetic build [#2] #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joverlee521
reviewed
Jul 18, 2024
joverlee521
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed workflow bits only, will leave scientific review to others.
* Update template files to remove instructions and placeholders * Add Genbank and GFF references * Bring in phylo workflow from pathogen-repo-guide and modify to work
* Drop to Python 3.11 in GitHub pre-commit CI, to match actual development practice * Clean up formatting of several files * Convert all Markdown links to use reference dictionary at end of file * Add `log` and `benchmark` to all Snakemake rules that didn't have them * Remove `dump_ncbi_dataset_report` rule
Also adds logging redirects everywhere
subrepo: subdir: "ingest/vendored" merged: "980c010" upstream: origin: "https://github.com/nextstrain/ingest" branch: "main" commit: "258ab8c" git-subrepo: version: "0.4.7" origin: "https://github.com/ingydotnet/git-subrepo/" commit: "c9ec2a6"
* Switch Auspice to default color-by=region * Remove extra `metadata_columns` (and associated config) when calling `augur export v2` * Move `--columns` arg of `augur traits` into config * Add `--metadata-id-columns` arg to `augur traits` invocation -- fixes issue where traits were being improperly inferred * Use a mid-point tree rooting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Updates yellow-fever phylo build to match pathogen-repo-guide standard.
Also updates various ingest curation steps to use
augur curate
instead of vendored ingest scripts.Related issue(s)
#2 #8
Checklist