Skip to content

Commit

Permalink
revert unintentional changes from cherry-pick
Browse files Browse the repository at this point in the history
  • Loading branch information
lukaspie committed Sep 23, 2024
1 parent c339f41 commit e28a739
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 8 deletions.
21 changes: 19 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ test ::

clean ::
$(RM) -rf $(BUILD_DIR)
$(RM) -rf $(BASE_CLASS_DIR)/$(NYAML_SUBDIR)
$(RM) -rf $(APPDEF_DIR)/$(NYAML_SUBDIR)
$(RM) -rf $(CONTRIB_DIR)/$(NYAML_SUBDIR)

prepare ::
$(PYTHON) -m dev_tools manual --prepare --build-root $(BUILD_DIR)
Expand Down Expand Up @@ -94,10 +97,24 @@ all ::
@echo "HTML built: `ls -lAFgh $(BUILD_DIR)/manual/build/html/index.html`"
@echo "PDF built: `ls -lAFgh $(BUILD_DIR)/manual/build/latex/nexus.pdf`"

$(BASE_CLASS_DIR)/%.nxdl.xml : $(BASE_CLASS_DIR)/$(NYAML_SUBDIR)/%.yaml
nyaml2nxdl $< --output-file $@

$(CONTRIB_DIR)/%.nxdl.xml : $(CONTRIB_DIR)/$(NYAML_SUBDIR)/%.yaml
nyaml2nxdl $< --output-file $@

$(APPDEF_DIR)/%.nxdl.xml : $(APPDEF_DIR)/$(NYAML_SUBDIR)/%.yaml
nyaml2nxdl $< --output-file $@

nxdl: $(YBC_NXDL_TARGETS) $(YCONTRIB_NXDL_TARGETS) $(YAPPDEF_NXDL_TARGETS)

nyaml:
$(MAKE) -f nyaml.mk


# NeXus - Neutron and X-ray Common Data Format
#
# Copyright (C) 2008-2022 NeXus International Advisory Committee (NIAC)
# Copyright (C) 2008-2024 NeXus International Advisory Committee (NIAC)
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
Expand All @@ -113,4 +130,4 @@ all ::
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
#
# For further information, see http://www.nexusformat.org
# For further information, see http://www.nexusformat.org
6 changes: 3 additions & 3 deletions contributed_definitions/NXcollectioncolumn.nxdl.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
#
# For further information, see http://www.nexusformat.org
-->
<definition xmlns="http://definition.nexusformat.org/nxdl/3.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" category="base" type="group" name="NXcollectioncolumn" extends="NXobject" xsi:schemaLocation="http://definition.nexusformat.org/nxdl/3.1 ../nxdl.xsd">
<definition xmlns="http://definition.nexusformat.org/nxdl/3.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" category="base" name="NXcollectioncolumn" extends="NXobject" type="group" xsi:schemaLocation="http://definition.nexusformat.org/nxdl/3.1 ../nxdl.xsd">
<doc>
Subclass of NXelectronanalyser to describe the electron collection
column of a photoelectron analyser.
Subclass of NXelectronanalyser to describe the electron collection column of a
photoelectron analyser.
</doc>
<field name="scheme" type="NX_CHAR">
<doc>
Expand Down
17 changes: 14 additions & 3 deletions contributed_definitions/NXmpes.nxdl.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
#
# For further information, see http://www.nexusformat.org
-->
<definition xmlns="http://definition.nexusformat.org/nxdl/3.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" category="application" type="group" name="NXmpes" extends="NXobject" xsi:schemaLocation="http://definition.nexusformat.org/nxdl/3.1 ../nxdl.xsd">
<definition xmlns="http://definition.nexusformat.org/nxdl/3.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" category="application" name="NXmpes" extends="NXobject" type="group" xsi:schemaLocation="http://definition.nexusformat.org/nxdl/3.1 ../nxdl.xsd">
<!--Pincelli, Rettig, Arora at fhi-berlin.mpg.de, Dobener at hu-berlin.de, 06/2022
Draft version of a NeXus application definition for photoemission,
It is designed to be extended by other application definitions
with higher granularity in the data description.-->
<doc>
This is the most general application definition for multidimensional
photoelectron spectroscopy.
Expand Down Expand Up @@ -192,6 +196,7 @@
<item value="channeltron"/>
</enumeration>
</field>
<!--ToDo: Representation of count rate calibration-->
<field name="detector_type" recommended="true">
<doc>
Description of the detector type.
Expand Down Expand Up @@ -303,8 +308,8 @@
<field name="atom_types" recommended="true">
<doc>
List of comma-separated elements from the periodic table
that are contained in the sample.
If the sample substance has multiple components, all
that are contained in the sample.
If the sample substance has multiple components, all
elements from each component must be included in `atom_types`.
</doc>
</field>
Expand All @@ -323,6 +328,11 @@
other metadata file. In the case these are not available, free-text description.
</doc>
</group>
<!--Problem: if the temperature is logged, the data is an array of temperature/timestamp pairs.
the timestamp NX_DATE_TIME structure of the timestamp can not be easily handled by just a field.
there is a base class for this, NXlog. The NIAC decided to use the same name (temperature) instead of the previous temperature_log.
how do I explain here in an appdef that temperature can be either NXnumber (single value or scanned array) or a NXlog?
It seems quite contorted to ask to create a separate timestamp array when we have a base class that handles it more elegantly.-->
<field name="temperature" type="NX_FLOAT" units="NX_TEMPERATURE">
<doc>
In the case of a fixed temperature measurement this is the scalar temperature of
Expand All @@ -339,6 +349,7 @@
<item value="reducing atmosphere"/>
</enumeration>
</field>
<!--Similar situation here, ca be a single number or a log.-->
<field name="gas_pressure" type="NX_FLOAT" units="NX_PRESSURE"/>
</group>
<group type="NXdata">
Expand Down

0 comments on commit e28a739

Please sign in to comment.