Fairmat 2024: additional fields in NXmonochromator #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
sanbrock
reviewed
Sep 29, 2024
sanbrock
reviewed
Sep 29, 2024
|
But the Schema will need to be updated for this most recent NIAC decision.
So start using it, knowing that soon the Schema will accept it.
…On Sun, Sep 29, 2024, 2:00 PM sanbrock ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In base_classes/NXmonochromator.nxdl.xml
<#1417 (comment)>
:
> @@ -60,6 +60,26 @@
<field name="energy_errors" type="NX_FLOAT" units="NX_ENERGY">
<doc>energy standard deviation</doc>
</field>
+ <field name="energy_dispersion" type="NX_FLOAT" units="NX_ANY">
+ <doc>
+ Energy dispersion at the exit slit, typically given as eV/mm.
+ </doc>
+ </field>
+ <field name="wavelength_dispersion" type="NX_FLOAT" units="NX_ANY">
+ <doc>
+ Wavelength dispersion at the exit slit.
units can be specified
—
Reply to this email directly, view it on GitHub
<#1417 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUME5YYU4S4YZNHLCOQ3ZZBE4XAVCNFSM6AAAAABOWOMOJOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZVHE2DAMJTGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Approved by NIAC vote, given the unit fixes listed above, in NIAC 2024 |
|
@sanbrock ready for review before other NIAC member can review. |
# Conflicts: # base_classes/NXmonochromator.nxdl.xml # base_classes/nyaml/NXmonochromator.yaml
# Conflicts: # base_classes/nyaml/NXmonochromator.yaml
# Conflicts: # base_classes/nyaml/NXmonochromator.yaml
# Conflicts: # base_classes/NXbeam.nxdl.xml # base_classes/nyaml/NXbeam.yaml # base_classes/nyaml/NXmonochromator.yaml
…ersion # Conflicts: # applications/NXarpes.nxdl.xml # applications/nyaml/NXarpes.yaml # base_classes/NXaperture.nxdl.xml # base_classes/NXbeam.nxdl.xml # base_classes/NXdata.nxdl.xml # base_classes/NXdetector.nxdl.xml # base_classes/NXentry.nxdl.xml # base_classes/NXenvironment.nxdl.xml # base_classes/NXinstrument.nxdl.xml # base_classes/NXroot.nxdl.xml # base_classes/NXsample.nxdl.xml # base_classes/NXsample_component.nxdl.xml # base_classes/NXsensor.nxdl.xml # base_classes/NXsource.nxdl.xml # base_classes/NXsubentry.nxdl.xml # base_classes/NXtransformations.nxdl.xml # base_classes/NXuser.nxdl.xml # base_classes/nyaml/NXaperture.yaml # base_classes/nyaml/NXbeam.yaml # base_classes/nyaml/NXdata.yaml # base_classes/nyaml/NXdetector.yaml # base_classes/nyaml/NXentry.yaml # base_classes/nyaml/NXenvironment.yaml # base_classes/nyaml/NXinstrument.yaml # base_classes/nyaml/NXmonochromator.yaml # base_classes/nyaml/NXprocess.yaml # base_classes/nyaml/NXroot.yaml # base_classes/nyaml/NXsample.yaml # base_classes/nyaml/NXsample_component.yaml # base_classes/nyaml/NXsensor.yaml # base_classes/nyaml/NXsource.yaml # base_classes/nyaml/NXsubentry.yaml # base_classes/nyaml/NXtransformations.yaml # base_classes/nyaml/NXuser.yaml
update copyright
lukaspie
force-pushed
the
fairmat-2024-nxmonochromator
branch
from
2fe1203 to
5542cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.