-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fairmat 2024: proposal on electron microscopy (EM) #1423
Open
lukaspie
wants to merge
1,189
commits into
nexusformat:main
Choose a base branch
from
FAIRmat-NFDI:fairmat-2024-em
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix docs CI to only keep orphan branch
…ate_system_set because that is what these conventions only talk about
Small modifications to clarify NXmpes
…ng-deployment Remove _sources build artifacts before docs deployment
…the rollett-holm formula fixes the build error with latex, locally at least it does
* Add depends for data field * Use `@reference` * use reference attribute in NXmpes and NXmpes_arpes * change text style * fix duplicated in reference attribute --------- Co-authored-by: Lukas Pielsticker <[email protected]>
Roll back changes to NXmpes/instrument/pressure_gauge
fix 2theta and use NXobject instead of collection.
Add radius to NXenergydispersion
* Including scattering vector components perpendicular and parallel to the surface of the sample those are mainly used for RSM diffraction technique. --------- Co-authored-by: Florian Dobener <[email protected]>
…tion of NXprocess
…trospectively I feel that this base class is too focused on EBSD surplus alone has an insufficient amount of concepts to warrant standardization right now, I like that there is a base class which allows to group signals of different (computed/or measured origin) that is standardized on the same physical or simulated material volume, however, this could also be achieved via specializing an NXimage in an application definition and augmenting it by NXprocess-relevant fields
…nal grouping in an appdef can also be achieved by just adding event_data_set(NXobject) and having current NXevent_data_em_set docstring there inside the appdef
…ation definition NXem, the top-level docstring and scientific context why having such a class is useful but the class has not been worked out in detail enough to warrant having an own base class, it should just be moved to NXem/entryID/em_sim also strengthening the point that NXem can be used for computer simulations of EM matters.
… of reserved NeXus suffix _set
…ng of the fundamental matter based description of the FAIRmat proposal like changes to rename NXion to NXatom and possibly NXmicrostructure to NXsystem
…it as a group in NXphase
…ture, groups. To increase the possibility for acceptance, the atom-probe-specific aspects of NXion now NXatom have been removed and will be reintroduced via NXapm_ion as a specialization of NXatom for usage in the field of atom probe
…, ii) NXstage_lab consolidation with NXmanipulator, and NXem appdef
…hich NXstage_lab will be replaced in NXem and NXapm appdefs via NXmanipulator from nexusformat#1424 augmented by remaining concepts and contextualizing top-level doc string from NXstage_lab pulled into the appdef. As a side effect thereby also docstring become more focused on the relevant techniques and a base class is not talking only with examples from atom probe
…h negotiation and coming to the conclusion that maybe indeed these base classes are tiny to warrant becoming part of the standard, instead NXcoordinate_system should be specialized in respective appdefs but the names sample_reference_frame, processing_reference_frame, and detector_reference_frame are good candidates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends heavily on others that make changes to existing base classes or introduce base classes that are to be used outside of APM as well. Thus, it will be much smaller once the discussion on these PRs is done and this particular branch here has been rebased:
#1407
#1408
#1410
#1412
#1413
#1414
#1415
#1419
#1420
#1486
There are however several new base classes that are currently only used within NXapm that are introduced here:
For a full list of dependant changes, see #1465