Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CONTRIBUTING.md #1509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding CONTRIBUTING.md #1509

wants to merge 3 commits into from

Conversation

phyy-nx
Copy link
Contributor

@phyy-nx phyy-nx commented Nov 7, 2024

Draft of a CONTRIBUTING guide, based on conversation from the recent Telco. This guide tries to layout the existing NeXus contribution guidelines, including issue and pull request guides.

Feedback welcome.

@rayosborn
Copy link
Contributor

LGTM although I would suggest capitalizing all the words in "NeXus international advisory committee."

@phyy-nx
Copy link
Contributor Author

phyy-nx commented Nov 7, 2024

👍

@prjemian
Copy link
Contributor

prjemian commented Nov 7, 2024

In the third paragraph, please change this text from:

describes a problem and answers "why" there needs to be work done

to:

describes a problem and answers "why" work needs to be done

@phyy-nx
Copy link
Contributor Author

phyy-nx commented Nov 8, 2024

Done. I purport this is merely echoing the constitution and established practices and therefore doesn't need a vote, but disagreement is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants