-
Notifications
You must be signed in to change notification settings - Fork 395
Add 3rd FASTQ file containing UMI sequences for the duplex-seq tiny dataset. #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
adamrtalbot
commented
May 15, 2024
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,10M1S+T 10M1S+T | ||
sample,id,single_end,fastq_1,fastq_2,fastq_3,read_structure | ||
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,,10M1S+T 10M1S+T | ||
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,https://github.com/nf-core/test-datasets/raw/fastquorum_umi_fastq_file/testdata/duplex-seq/tiny/SRR6109255_3.fastq.gz,11S+T 11S+T +M |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated before PR is merged:
Suggested change
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,https://github.com/nf-core/test-datasets/raw/fastquorum_umi_fastq_file/testdata/duplex-seq/tiny/SRR6109255_3.fastq.gz,11S+T 11S+T +M | |
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_3.fastq.gz,11S+T 11S+T +M |
15 tasks
@adamrtalbot sorry to be a pedant, but could you submit a PR from a fork, as per this: https://nf-co.re/docs/contributing/test_data_guidelines#adding-new-test-data |
Done: #1205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds third FASTQ which contains only UMI sequences for testing with read structures that use a separate FASTQ file. Use bases mask
11S+T 11S+T +M
which has been included in the tiny samplesheet.