Skip to content

Add 3rd FASTQ file containing UMI sequences for the duplex-seq tiny dataset. #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

adamrtalbot
Copy link

@adamrtalbot adamrtalbot commented May 15, 2024

Adds third FASTQ which contains only UMI sequences for testing with read structures that use a separate FASTQ file. Use bases mask 11S+T 11S+T +M which has been included in the tiny samplesheet.

@adamrtalbot adamrtalbot mentioned this pull request May 15, 2024
10 tasks
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,10M1S+T 10M1S+T
sample,id,single_end,fastq_1,fastq_2,fastq_3,read_structure
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,,10M1S+T 10M1S+T
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,https://github.com/nf-core/test-datasets/raw/fastquorum_umi_fastq_file/testdata/duplex-seq/tiny/SRR6109255_3.fastq.gz,11S+T 11S+T +M
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated before PR is merged:

Suggested change
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,https://github.com/nf-core/test-datasets/raw/fastquorum_umi_fastq_file/testdata/duplex-seq/tiny/SRR6109255_3.fastq.gz,11S+T 11S+T +M
SRR6109255,SRR6109255,false,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_1.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_2.fastq.gz,https://raw.githubusercontent.com/nf-core/test-datasets/fastquorum/testdata/duplex-seq/tiny/SRR6109255_3.fastq.gz,11S+T 11S+T +M

@nh13
Copy link
Member

nh13 commented May 16, 2024

@adamrtalbot sorry to be a pedant, but could you submit a PR from a fork, as per this: https://nf-co.re/docs/contributing/test_data_guidelines#adding-new-test-data

@nh13 nh13 closed this May 16, 2024
@nh13 nh13 deleted the fastquorum_umi_fastq_file branch May 16, 2024 20:02
@adamrtalbot
Copy link
Author

Done: #1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants