Skip to content

Fix modules meta.yml file structure #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Apr 7, 2025

Close: #3248

Code to fix/update:

@mirpedrol mirpedrol marked this pull request as ready for review April 17, 2025 09:29
@mirpedrol
Copy link
Member Author

The modules from GitLab, which we use for the CI tests, need to be fixed. But fixing this will break all other tools' tests. So I will mark the PR for review and fix the tests right before merging.
This should be a coordinated merge together with the PR on the website and the modules repo + an additional PR updating all modules to avoid linting errors there (the modules repo uses the dev version). And I would do all this before the release, to prevent people contributing to modules from having to use the dev version of tools.

inputs.append(channel_elements)
elif len(channel_elements) > 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elif len(channel_elements) > 0:
elif len(channel_elements) == 0:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be == 1 if we want to use the equal 😄

Suggested change
elif len(channel_elements) > 0:
elif len(channel_elements) == 1:

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we want to do this with pydantic?

@@ -72,7 +72,7 @@ def meta_yml(module_lint_object: ComponentLint, module: NFCoreComponent, allow_m
# Confirm that the meta.yml file is valid according to the JSON schema
valid_meta_yml = False
try:
with open(Path(module_lint_object.modules_repo.local_repo_dir, "modules/meta-schema.json")) as fh:
with open(Path("/Users/jmir/Work/modules", "modules/meta-schema.json")) as fh:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks! I was testing and missed that I pushed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants