-
Notifications
You must be signed in to change notification settings - Fork 201
Fix modules meta.yml file structure #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
The modules from GitLab, which we use for the CI tests, need to be fixed. But fixing this will break all other tools' tests. So I will mark the PR for review and fix the tests right before merging. |
inputs.append(channel_elements) | ||
elif len(channel_elements) > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elif len(channel_elements) > 0: | |
elif len(channel_elements) == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be == 1
if we want to use the equal 😄
elif len(channel_elements) > 0: | |
elif len(channel_elements) == 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't we want to do this with pydantic?
@@ -72,7 +72,7 @@ def meta_yml(module_lint_object: ComponentLint, module: NFCoreComponent, allow_m | |||
# Confirm that the meta.yml file is valid according to the JSON schema | |||
valid_meta_yml = False | |||
try: | |||
with open(Path(module_lint_object.modules_repo.local_repo_dir, "modules/meta-schema.json")) as fh: | |||
with open(Path("/Users/jmir/Work/modules", "modules/meta-schema.json")) as fh: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops thanks! I was testing and missed that I pushed it
Close: #3248
Code to fix/update: